On Mon, Sep 24, 2012 at 08:50:47PM +0400, Alexander Shiyan wrote: > On Wed, 5 Sep 2012 13:24:33 -0700 > Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > ... > > > +config SERIAL_SCCNXP > > > + bool "SCCNXP serial port support" > > > + depends on !SERIAL_SC26XX > > > + select SERIAL_CORE > > > + default n > > > + help > > > + This selects support for an advanced UART from NXP (Philips). > > > + Supported ICs are SCC2681, SCC2691, SCC2692, SC28L91, SC28L92, > > > + SC28L202, SCC68681 and SCC68692. > > > + Positioned as a replacement for the driver SC26XX. > > > > This driver can be built as a module, right? If so, please change this > > to a tristate variable, not a "bool". I don't feel like always building > > it into my kernels :) > > Care to send a follow-on patch fixing this up? > > I'm not sure whether the driver works as a module, as in the case of the > module, we can not setup at least IO-address and IRQ parameters. Or, we are > need to create module_param variables. You should not use module parameters for this type of thing. What about platform data instead? gre gk-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html