Re: [PATCH] tty: prevent unnecessary work queue lock checking on flip buffer copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

2012/9/20 Alan Cox <alan@xxxxxxxxxxxxxxx>:
>
> This seems reasonable, but given its also relevant for upstream it
> would be nice to get it without the ifdef in upstream.
>
> The corner case is when the tty->low_latency flag is flipped but the
> drivers should handle that gracefully and if not we should fix them so
> you can get your 100uS.
>
> Alan

Actually this patch is related to my previous patch "tty: cleanup
duplicate functions in tty_buffer". Some drivers call the
tty_schedule_flip() function instead of tty_flip_buffer_push(). In
that case the work queue is always used, regardless the
tty->low_latency flag. That's why tried to get rid of the
tty_schedule_flip() function.

But from the first review remarks on the "tty: cleanup duplicate
functions in tty_buffer" patch, that patch seems to be invalid. So in
that case this patch is invalid also.

Regards,
Ivo Sieben
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux