On Thu, Sep 20, 2012 at 11:45:46AM +0200, Linus Walleij wrote:
> + if ((termios->c_ispeed > max_baud) ||
> + (termios->c_ospeed > max_baud)) {
> + dev_err(port->dev,
> + "requested a baud rate > clock/mindivisor\n");
> + return;
> + }
Why do we need this check? In any case, this is incorrect behaviour
just to 'return' from this function without doing anything. You just
produce an error message, and userspace believes that it's request
has been satisfied.
uart_get_baud_rate() is there precisely to do the right thing for invalid
baud rates, which is to fallback to the old termios setting (and update
the new termios with that) if the old termios setting satisifies the
limits, if not it falls back to something within the limited range.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
