On 09/19/2012 06:40 PM, Anton Vorontsov wrote: > Hi all, > > In v8, addressed Jason's comments: > > - Changed kgdb_enable_nmi() weak function to kgdb_arch callbck; > - We no longer register disable_nmi command if arch does not register > KGDB NMI handling (i.e. not filling kgdb_arch.enable_nmi callback); > - The same is for ttyNMI: if architecure does not provide us with > enable_nmi call, we don't need the tty device. Of course, there is no > way to tell wether a specific serial device can be used for NMI > debugging, as it is not serial-device specific, but specific to > whether IRQ can be rerouted to an NMI (for most our cases, pretty > much every IRQ can be rerouted, e.g. a hot-pluggable serial device on > a PCI bus). > - Rebased on the latest and greatest tty-next, just in case. I have the kgdb regression builder running right now (it will be done in about 1 hour), and so far it picked up one new warning. drivers/tty/serial/kgdb_nmi.c: In function 'kgdb_nmi_poll_one_knock': drivers/tty/serial/kgdb_nmi.c:161: warning: field width should have type 'int', but argument 4 has type 'size_t' Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
