ping..
On 12 September 2012 12:00, Sachin Kamat <sachin.kamat@xxxxxxxxxx> wrote:
> Return the value returned by the failing function instead
> of -1 (which does not convey the right error information).
>
> Fixes the following smatch warning:
> drivers/tty/serial/samsung.c:1687 s3c24xx_serial_modinit() info:
> why not propagate 'ret' from uart_register_driver() instead of -1?
>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
> drivers/tty/serial/samsung.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index bdaa06f..8eef114 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1684,7 +1684,7 @@ static int __init s3c24xx_serial_modinit(void)
> ret = uart_register_driver(&s3c24xx_uart_drv);
> if (ret < 0) {
> pr_err("Failed to register Samsung UART driver\n");
> - return -1;
> + return ret;
> }
>
> return platform_driver_register(&samsung_serial_driver);
> --
> 1.7.4.1
>
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
