Re: [PATCH 2/2] 8250: blacklist IR ports

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu,  6 Sep 2012 23:20:32 +0100
Sean Young <sean@xxxxxxxx> wrote:

> These ports should not be probed, but we need to keep track of them so we
> can prevent the legacy (non-PNP) probe of serial ports from touching them
> too.

I want to have a think about getting the ordering right so we don't
shuffle the ports on existing boxes for the first half. For the second
part

> 
> Signed-off-by: Sean Young <sean@xxxxxxxx>
> ---
>  drivers/tty/serial/8250/8250.c     | 16 ++++++++++++++--
>  drivers/tty/serial/8250/8250_pnp.c | 23 ++++++++++++++++++-----
>  include/linux/serial_core.h        |  3 ++-
>  3 files changed, 34 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250/8250.c b/drivers/tty/serial/8250/8250.c
> index bc25874..ea9166b 100644
> --- a/drivers/tty/serial/8250/8250.c
> +++ b/drivers/tty/serial/8250/8250.c
> @@ -290,6 +290,9 @@ static const struct serial8250_config uart_config[] = {
>  				  UART_FCR_R_TRIG_00 | UART_FCR_T_TRIG_00,
>  		.flags		= UART_CAP_FIFO,
>  	},
> +	[PORT_IR] = {
> +		.name		= "IR port"

Please use "CIR port". We have SIR and FIR serial ports (IrDA) too that we
do drive via tty. PORT_8250_CIR for the type might be best too - it means
the tools know what they are looking at and can report it sensibly.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux