On 08/21/2012 03:35 PM, Alan Cox wrote: > From: Alan Cox <alan@xxxxxxxxxxxxxxx> > > These are used with the tty_port flags which are tty generic so move the > flags into a more sensible place. This then makes it possible to add > helpers such as those suggested by Huang Shijie. Yes, the idea looks good to me. I was actually thinking of the same. But there are two issues with this patch (see below). > --- a/include/linux/serial.h > +++ b/include/linux/serial.h > @@ -15,6 +15,8 @@ > #ifdef __KERNEL__ > #include <asm/page.h> > > +#include <linux/tty_flags.h> > + There are no minus lines in serial.h -- we have two copies of the flags now? That looks insane. The flags are a user API. You concealed them by the #include inside the __KERNEL__ section (if I consider we do not have the flags defined twice). And if we move the include outside of the __KERNEL__ section, we shall update Kconfig, so that the new header is installed. > /* > * Counters of the input lines (CTS, DSR, RI, CD) interrupts > */ > diff --git a/include/linux/tty.h b/include/linux/tty.h > index 69a787f..dbebd1e 100644 > --- a/include/linux/tty.h > +++ b/include/linux/tty.h > @@ -43,6 +43,7 @@ > #include <linux/tty_driver.h> > #include <linux/tty_ldisc.h> > #include <linux/mutex.h> > +#include <linux/tty_flags.h> thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
