On Tue, Aug 21, 2012 at 10:47 PM, Tony Prisk <linux@xxxxxxxxxxxxxxx> wrote: > Converted the existing arch-vt8500 gpio to a platform_device. > Added support for WM8505 and WM8650 GPIO controllers. (...) > + unsigned val; I asked about the datatype for this "val", it sure isn't "unsigned". I suspected the registers were only 8bit and so it should be u8. But atleast use u32 if you must use all these bits. (...) > + val = readl(vt8500_chip->base + vt8500_chip->regs->en); > + val |= BIT(offset); > + writel(val, vt8500_chip->base + vt8500_chip->regs->en); BTW: have you considered [readl|writel]_relaxed? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
