> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -53,7 +53,7 @@ source "drivers/tty/serial/Kconfig"
>
> config TTY_PRINTK
> bool "TTY driver to output user messages via printk"
> - depends on EXPERT
> + depends on EXPERT && TTY
A lot of these could be done better with an if I think - notably the
serial one and perhaps some of the input ones if the tty users were
bunched together.
> config MOUSE_PS2
> tristate "PS/2 mouse"
> + depends on TTY
It shouldn't. It would be good to understand why this occurs.
> diff --git a/include/linux/tty.h b/include/linux/tty.h
> index 5dbb3cb..c1406e3 100644
> --- a/include/linux/tty.h
> +++ b/include/linux/tty.h
> @@ -377,7 +377,12 @@ extern void tty_write_flush(struct tty_struct *);
>
> extern struct ktermios tty_std_termios;
>
> +#ifdef CONFIG_TTY
> extern void console_init(void);
> +#else
> +static inline void console_init(void)
> +{ }
> +#endif
Please can you bunch the whole lot up into one #if defined() / #else /
#endif
rather than lots.
Otherwise this looks very sensible to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
