Re: [PATCH] Remove BUG_ON from n_tty_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Subject should include "tty:" prefix.

Sorry, just forgot about it for the second time;-/
Can I force git format-patch to add it somehow?

This usually is done in two lines:

if (WARN_ON())
	return;

Thanks, good point, new patch sent.

Additionally, second BUG_ON(!tty->read_buf) in n_tty_read() should be
probably replaced too.

I don't think so.
In the first case, we are not running, so there might be no operation on tty running. We still don't understand how it can happen that someone closes the tty, and then read operation is called, however at least there is no (known) running operation. In the other case, we have just be rescheduled - so we are definitely in operation, and if tty is closed while we are just sleeping, I would still keep BUG_ON() there. Despite we haven't seen any panics on that place, have we?

Thanks,
-Stanislav
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux