Re: [PATCH V2] [tty] Fix possible race in n_tty_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 09 Aug 2012 13:24:42 +0200
Stanislav Kozina <skozina@xxxxxxxxxx> wrote:

> I believe that BUG_ON is different issue.

Ok thats what I was thinking.. I was a bit confused about that.

> I will submit a separate patch changing the BUG_ON to return, I believe 
> it's still better to drop a n_tty_read() rather than panic whole system.
> But I still don't understand how this can happen - that we have a tty 
> operational without a buffer allocated. There still must be some other race.

Nor me - a WARN_ON and return would be better perhaps - it will at least
then spew an error into the logs

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux