Hi Joe On Mon, Jul 9, 2012 at 12:09 AM, Joe Perches <joe@xxxxxxxxxxx> wrote: > On Sun, 2012-07-08 at 23:56 +0200, David Herrmann wrote: >> We want to print the kernel log to all FBs so we need a console driver. >> This registers the driver on startup and writes all messages to all >> registered fblog instances. > > Hi David. Trivia only: > >> diff --git a/drivers/video/console/fblog.c b/drivers/video/console/fblog.c > [] >> @@ -47,6 +71,107 @@ static struct fblog_fb *fblog_fbs[FB_MAX]; >> static bool active = 1; >> >> #define to_fblog_dev(_d) container_of(_d, struct fblog_fb, dev) >> +#define FBLOG_STR(x) x, sizeof(x) - 1 > > That's a rather ugly macro. But handy ;) I've removed it and replaced the call below with a local variable which works fine too and seems to be even shorter than with this macro. >> +static void fblog_buf_resize(struct fblog_buf *buf, size_t width, >> + size_t height) >> +{ >> + u16 **lines = NULL; >> + size_t i, j, minw, minh; >> + >> + if (buf->height == height && buf->width == width) >> + return; >> + >> + if (width && height) { >> + lines = kzalloc(height * sizeof(char*), GFP_KERNEL); > > sizeof(char *) is a bit more kernel style like. Thanks, both fixed. David -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html