On Sun, Jul 01, 2012 at 12:44:01PM +0200, Alessandro Rubini wrote: > How should I address the problem? (original code, published on > sourceforge was simply replicating a number of amba drivers into pci > drivers, but I don't think massive code duplication is ever sensible, > thus I preferred to reuse the existing drivers). I think the answer is... those primecell drivers need fixing in some way. Re-defining CS, DS and ES in drivers is rather silly given that they're x86 segment register names - so if PL330 can be fixed to make its names more specific, that sorts it out. As for PL08x, which depends on asm/hardware/pl080.h, I think that's going to have to be a config dependency - it would be nice to move that header into drivers/dma and make it private to the amba-pl08x driver, but we have definitions in there which platforms supply to the pl08x driver via platform data. I'd rather not stuff the register definitions into include/linux/platform_data/... Note also that hpa has only reported the first errors he encountered, so there may be more, and that's somehting which needs checking. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
