> On Mon, Mar 12, 2012 at 08:32:21AM +0000, Russell King - ARM Linux wrote: > > On Mon, Mar 12, 2012 at 09:25:50AM +0100, Linus Walleij wrote: > > > diff --git a/drivers/tty/serial/amba-pl011.c > > > b/drivers/tty/serial/amba-pl011.c index 6800f5f..ff3fed0 100644 > > > --- a/drivers/tty/serial/amba-pl011.c > > > +++ b/drivers/tty/serial/amba-pl011.c > > > @@ -224,6 +224,11 @@ static int pl011_fifo_to_tty(struct uart_amba_port > *uap) > > > uart_insert_char(&uap->port, ch, UART011_DR_OE, ch, flag); > > > } > > > > > > > What if we really do end up receiving some characters here? > > > > > + /* RXIS but RXFE? Just clear the interrupt */ > > > + if(unlikely(fifotaken == 0)) > > > + writew(UART011_RTIS | UART011_RXIS, > > > + uap->port.membase + UART011_ICR); > > BTW, I don't see why we need any of this stuff. Actually, I meant my patch applied alone, not with your patch. My thought was the problem we're trying to handle is undocumented and is not guaranteed not to happen again. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
