Hi Greg! First -- as you probably have guessed already -- I'm not (not yet?) :-) too familiar with the Linux kernel patch submission process. I have spent quite some time reading the included documentation, but apparently missed some details... :-) On Fri, 9 Mar 2012 09:10:07 -0800, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > On Fri, Mar 09, 2012 at 05:38:49PM +0100, Thomas Schwinge wrote: > > As of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the > > endianess-agnostic I/O accessor functions. > > Please always put a human readable description of what the git id is, so > that we have a chance to understand what is going on. Sorry. ``sh: machvec IO death.'' -- well, the essential part what I'm fixing here is that before this commit readw (and friends, such as ioread16) didn't do any endianess modification of the data, but directly invoked __raw_readw, whereas after 37b7a978 they do such modification by means of filtering through le16_to_cpu (in the readw/ioread16 case). This is where things break for big endian (but not little endian, where this is a no-op). > Are these patches supposed to be going through the sh tree, or the > serial tree to Linus? I'm assuming that Paul Mundt will handle the whole lot in an SH tree. Paul, by the way, if that's more convenient I can also publish my Git tree. > And watch your To: line, it seemed to be munged :( Yes. By means of scripts/get_maintainer.pl (and some manual adjustments) I created the Cc: lists that are part of my commits' log messages. Then, I just had git send-email send that out, without explicitly specifying a primary recipient (To: line). I assume I should have put Paul there? On this patch, the linux-serial was Cced (as suggested by scripts/get_maintainer.pl), as it touches a TTY/serial driver, and I wanted to make sure to give you an opportunity to review that the patch doesn't introduce any breakage on non-SH architectures, for example. (Despite its indicative name, sh-sci also seems to be used on some ARM boards.) > confused, Sorry; will hopefully improve. :-) Grüße, Thomas
Attachment:
pgpqxbnN6fxWa.pgp
Description: PGP signature
