Re: [PATCH 1/9] tty: make receive_buf() return the amout of bytes received

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> For a first step, will always return that we received everything.
> This make sure to we don't break anything when we will check receive_buf
> return value.


What about recursive calls ? We have some of those due to bugs elsewhere
in the code - eg selection.c. I don't wish to throw spanners in the works
of this effort but you can't actually make it work until you fix

selection.c
tty_io.c: tiocsti
n_tty: n_tty_set_room

The first two are unsafe recursive calls, the third one is totally broken
on any port with low latency set and can result in all kinds of
interesting failure cases.

Basically you've got to actually address the fact that code is calling
the ldisc methods wrongly, in parallel, without locking, and in an unsafe
fashion that in some cases can arbitarily recurse.

Until that is done you are never going to be able to debug the changes
because it'll crash anyway if you poke it the right way.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux