On Thu, 1 Mar 2012 21:33:21 -0500 Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > The two callers to serial_out_sync() have a struct port right > there in scope, but then pass in a struct 8250_port which then > is locally resolved to a struct port. This change I don't like. It means serial_out_sync and serial_out end up with different parameters which seems odd to say the least. You then extend this oddity by adding helpers for port_in/out but not the sync one. Otherwise it all looks good to me. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
