On Thursday 01 March 2012, Alan Cox wrote:
> @@ -1407,6 +1425,7 @@ int vt_move_to_console(unsigned int vt, int alloc)
> return -EIO;
> }
> console_unlock();
> + /* Review: I don't see why we need tty_lock here FIXME */
> tty_lock();
> if (vt_waitactive(vt + 1)) {
> pr_debug("Suspend: Can't switch VCs.");
I'm pretty sure I only added this in be1bc288 "tty: introduce
wait_event_interruptible_tty" so I could release the mutex again in
vt_event_wait.
All other callers of that function hold it, so it needs to be released
in vt_event_wait and that can only be done if it's known to be held first.
Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
