> + /* Setup UART clock, checking for board specific clocks. */ > + uartclk = DEFAULT_UARTCLK; > + > + board_name = dmi_get_system_info(DMI_BOARD_NAME); > + if (board_name && strstr(board_name, "CM-iTC")) > + uartclk = CMITC_UARTCLK; > + > + board_name = dmi_get_system_info(DMI_PRODUCT_NAME); > + if (board_name && strstr(board_name, "Fish River Island II")) > + uartclk = FRI2_UARTCLK; > + > + port->uartclk = uartclk; This is confusing, you load product name into a variable called board_name ?? perhaps "name" would be clearer ? > > if (options) > uart_parse_options(options, &baud, &parity, &bits, &flow); > @@ -1566,12 +1580,16 @@ static struct eg20t_port *pch_uart_init_port(struct pci_dev *pdev, > if (!rxbuf) > goto init_port_free_txbuf; > > + /* Setup UART clock, checking for board specific clocks. */ > uartclk = DEFAULT_UARTCLK; > > - /* quirk for CM-iTC board */ > board_name = dmi_get_system_info(DMI_BOARD_NAME); > if (board_name && strstr(board_name, "CM-iTC")) > - uartclk = 192000000; /* 192.0MHz */ > + uartclk = CMITC_UARTCLK; > + > + board_name = dmi_get_system_info(DMI_PRODUCT_NAME); > + if (board_name && strstr(board_name, "Fish River Island II")) > + uartclk = FRI2_UARTCLK; And we have two locations so this is going to get missed on updates. Can we have one function for this please ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
