On 02/21/2012 08:26 PM, Tomoya MORINAGA wrote: > 2012年2月22日12:36 Darren Hart <dvhart@xxxxxxxxxxxxxxx>: >> This patch series allows for a functional early serial console as well >> as using the UART after boot. It leaves the CM-iTC board alone. So this >> seems to enable all use cases, while forcing 192MHz breaks the FRI2 >> early serial console. I don't see an advantage to that approach other >> than the obviously simpler code (which is nice, but should not trump >> functionality). > > Your quark "Fish River Island II" is OK. > My concern is default uart_clock remains 1.8432 MHz. > Like I said the advantage before, I think this should be 192MHz not 1.8432 MHz. > > Or do you have any reason 1.8432 MHz should be set as PCH_UART default clock. Ah, that's a good point. We can add a patch to this series that sets the default to 192MHz, drops the CM-iTC quirk, and does nothing in pch_phub probe for the FRI2. Would you care to Ack this series and then follow-up with a patch set the default clock to 192MHz? -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html