Currently the memory region is not released the folowing error is
observed.
/testsuites # insmod omap-serial.ko
[ 130.746917] omap_uart omap_uart.0: memory region already claimed
[ 130.753143] omap_uart: probe of omap_uart.0 failed with error -16
[ 130.759338] omap_uart omap_uart.1: memory region already claimed
[ 130.765380] omap_uart: probe of omap_uart.1 failed with error -16
[ 130.771606] omap_uart omap_uart.2: memory region already claimed
[ 130.777679] omap_uart: probe of omap_uart.2 failed with error -16
[ 130.783905] omap_uart omap_uart.3: memory region already claimed
[ 130.789947] omap_uart: probe of omap_uart.3 failed with error -16
Fix it by releasing the memory region.
Cc: Govindraj.R <govindraj.raja@xxxxxx>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx>
---
changes from the rfc version -
move the release after the unmap.
drivers/tty/serial/omap-serial.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 8c6f137..16aa4f0 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1480,9 +1480,12 @@ do_release_region:
static int serial_omap_remove(struct platform_device *dev)
{
struct uart_omap_port *up = platform_get_drvdata(dev);
+ struct resource *r;
if (up) {
iounmap(up->port.membase);
+ r = platform_get_resource(dev, IORESOURCE_MEM, 0);
+ release_mem_region(r->start, resource_size(r));
pm_runtime_disable(&up->pdev->dev);
uart_remove_one_port(&serial_omap_reg, &up->port);
pm_qos_remove_request(&up->pm_qos_request);
--
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
