On Fri, 2 Sep 2011 12:20:50 +0200 Søren holm <sgh@xxxxxx> wrote: > Hi > > Here is my patch to add EFR-support for XR17D15x > Do you have any comments, since this is my first patch to the kernel ? Codewise it looks fine Two things though - run changes through scripts/checkpatch.pl (and it'll tell you off for the // comment...) and actually inline the patch rather than attach it so it is easy for people to comment on. The important bits of it however - the actual implementation looks right to me and sensibly implemented. Possibly it should instead override serial_out/in to use the different EFR that way but given this is one spot only I don't think its worth the extra complexity - and if other changes later make it worth doing it's easy to change. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
