On 08/31/2011 11:28 PM, Alan Cox wrote: > On Wed, 31 Aug 2011 21:24:58 +0200 > Jiri Slaby <jslaby@xxxxxxx> wrote: > >> I'm getting build errors such as: >> .../tty/serial/max3107.c: In function ‘put_data_to_circ_buf’: >> .../tty/serial/max3107.c:149:2: error: implicit declaration of function ‘tty_insert_flip_string’ >> >> Those drivers need to include linux/tty_flip.h. The question is >> whether we want to fix them at all. As they are broken for some time >> already and nobody noticed... > > Config options randomly including it ? Ah, no, ignore that comment. I realized that I removed linux/tty_flip.h inclusion from serial_core.h. I moved the big inlines out of the header and the inclusion was no longer needed there. Hence these failures. And I think there will be more. So please apply the patch, it's correct, except the changelog. thanks, -- js suse labs -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
