On Tuesday 12 July 2011 22:43:20 Jiri Slaby wrote: > tty_wakeup can be called from any context. So there is no need to have > an extra tasklet for calling that. Hence save some space and remove > the tasklet completely. > > Signed-off-by: Jiri Slaby <jslaby@xxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxx> > Cc: Alan Cox <alan@xxxxxxxxxxxxxxx> This is probably ok, but strictly speaking, we we cannot call tty_wakeup from any context: not while holding the ldisc_mutex, i.e. from ld->ops->{open,close}. I don't see a reason why we would ever do that, but it's the only explanation I have why the tasklet was introduced intially. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html