RE: [PATCH] tty/serial: Fix XSCALE serial ports, e.g. ce4100

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Stephen Warren wrote at Friday, June 17, 2011 9:45 AM:
> Commit 4539c24fe4f92c09ee668ef959d3e8180df619b9 "tty/serial: Add
> explicit PORT_TEGRA type" introduced separate flags describing the need
> for IER bits UUE and RTOIE. Both bits are required for the XSCALE port
> type. While that patch updated uart_config[] as required, the auto-probing
> code wasn't updated to set the RTOIE flag when an XSCALE port type was
> detected. This caused such ports to stop working. This patch rectifies
> that.

Alan, Greg,

Does this patch look OK? Seems like it should go into 3.0, but I don't see
it ack'd or committed anywhere yet.

Thanks.

> Reported-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Tested-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>
> ---
>  drivers/tty/serial/8250.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c
> index f11df87..f1422a6 100644
> --- a/drivers/tty/serial/8250.c
> +++ b/drivers/tty/serial/8250.c
> @@ -1107,7 +1107,7 @@ static void autoconfig_16550a(struct uart_8250_port *up)
>  			 */
>  			DEBUG_AUTOCONF("Xscale ");
>  			up->port.type = PORT_XSCALE;
> -			up->capabilities |= UART_CAP_UUE;
> +			up->capabilities |= UART_CAP_UUE | UART_CAP_RTOIE;
>  			return;
>  		}
>  	} else {
> --
> 1.7.0.4

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux PPP]     [Linux FS]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Linmodem]     [Device Mapper]     [Linux Kernel for ARM]

  Powered by Linux