On Mon, Jun 27, 2011 at 11:45 PM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > Only one platform ever sets the UPIO_AU iotype, so it's > cleaner to define the handlers in the code that actually > requires it, rather than building the same logic into > every 8250 driver. > > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx> > Cc: Ralf Baechle <ralf@xxxxxxxxxxxxxx> > Cc: Manuel Lauss <manuel.lauss@xxxxxxxxxxxxxx> > Cc: Greg Kroah-Hartman <gregkh@xxxxxxx> > Cc: linux-serial@xxxxxxxxxxxxxxx > --- > arch/mips/alchemy/common/platform.c | 50 ++++++++++++++++++++++++++++++ > drivers/tty/serial/8250.c | 58 ----------------------------------- > 2 files changed, 50 insertions(+), 58 deletions(-) > > diff --git a/arch/mips/alchemy/common/platform.c b/arch/mips/alchemy/common/platform.c > index 3b2c18b..750441f 100644 > --- a/arch/mips/alchemy/common/platform.c > +++ b/arch/mips/alchemy/common/platform.c [...] > @@ -55,6 +103,8 @@ static void alchemy_8250_pm(struct uart_port *port, unsigned int state, > UPF_FIXED_TYPE, \ > .type = PORT_16550A, \ > .pm = alchemy_8250_pm, \ > + .serial_in = au_serial_in, \ > + .serial_out = au_serial_out \ > } This is very strange: Just this part alone (leaving 8250.c intact) screws everything up. The assembly for au_serial_in/out is identical in both 8250.o and arch/mips/alchemy/common/platform.o (renamed the functions here obviously) I have no idea what's wrong... Manuel -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
