On Wed, Jun 22, 2011 at 2:50 AM, Alexander Stein <alexander.stein@xxxxxxxxxxxxxxxxxxxxx> wrote: > + if (priv->use_msi) > + pci_disable_msi(pdev); Trivial nit: pci_disable_msi() is safe even if you didn't enable msi. So you can drop the use_msi flag (the PCI layer has dev->msi_enabled internally to track this), and just always call pci_disable_msi(). - R. -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html