On Tue, May 31, 2011 at 11:22:39AM +0900, Tomoya MORINAGA wrote: > Intel EG20T PCH has UART device which is compatible with 8250. > Currently, with general configuration, the PCH UART driver is not loaded but > 8250 standard driver is loaded. > Therefore, in case of using PCH UART driver, need to disable 8250 pci function. > However, this procedure is not best solution. > This patch, in 8250_pci, if the device is the PCH or the family IOH, > '-ENODEV' is returned. > As a result, disabling 8250-pci processing becomes unnecessary. [...] > +static int pci_eg20tpch_init(struct pci_dev *dev) > +{ > + return -ENODEV; > +} You could name it just return_ENODEV() or similar and then while looking at the device-id table you would know right away what this entry is doing. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html