On Thu, May 19, 2011 at 02:03:43PM -0500, Michael Reed wrote:
> When working on the 8250_pci driver on PPC, the rmmod command was resulting in a crash when removing the module. The serial8250_do_pm() is called after the memory are deallocated, meaning that serial8250_set_sleep->serial_outp() will try to write to a
> position that is invalid, crashing the system. The purpose of this patch is to correct that issue.
> This patch was created against 2.6.38.6
>
> Patch-created-by: Breno Leitao <leitao@xxxxxxxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
> Cc: Breno Leitao <leitao@xxxxxxxxxxxxxxxxxx>
> Cc: Scott Kilau <scottk@xxxxxxxx>
> Signed-off-by: Michael Reed <mreed@xxxxxxxxxxxxxxxxxx>
> ---
> drivers/tty/serial/8250.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/8250.c b/drivers/tty/serial/8250.c
> index b3b881b..7617cde 100644
> --- a/drivers/tty/serial/8250.c
> +++ b/drivers/tty/serial/8250.c
> @@ -145,6 +145,8 @@ struct uart_8250_port {
> unsigned char mcr_mask; /* mask of user bits */
> unsigned char mcr_force; /* mask of forced bits */
> unsigned char cur_iotype; /* Running I/O type */
> +#define SERIAL8250_DYING 1
> + unsigned char status;
Ick, is this really necessary?
A bitfield would be best, only if that is the absolute last way to do
this (and I really think it isn't...)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
