> +#elif defined(CONFIG_SERIAL_8250_IRBLASTER)
> +/**
> + * regmap_in - input register mapper, specific for Cisco PowerTV UARTS
> + */
> +static const u8
> + regmap_in[8] = {
> + [UART_RX] = 0x18,
> + [UART_IER] = 0x04,
> + [UART_IIR] = 0x00,
> + [UART_LCR] = 0x08,
> + [UART_FCR] = 0x0c,
> + [UART_LSR] = 0x1c,
This is already completely unmaintainable and we are pushing stuff *out*
of this driver. Please provide you own ->serial_in and serial_out method
instead. That'll keep all the noise buried in your driver where it
belongs.
It looks like pretty much all of the rest of the errata you can then
cover up in your own code by correcting the register returns and/or doing
extra I/O in your serial_in and serial_out method to hide the brokenness
of the underlying device.
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
