On Fri, 25 Mar 2011 11:45:56 +0100 Jiri Slaby <jslaby@xxxxxxx> wrote: > Under certain circumstances uart_dtr_rts might cause an oops. It dies > because port->tty is NULL. To fix this, let's take a reference of > port->tty by tty_port_tty_get. And if it is not there already, fail > gracefully. The uart helper layer assumes here (and a couple of other spots) that the IRQ handler for the tty takes the port lock. I think the *right* fix is probably to pass port not port->tty into the helper in the first place but that seems to ripple into a lot of drivers. (passing port->tty to things that then go tty->port is braindead and causes half the mess in the tty/serial code) -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
