On Tue, 8 Mar 2011 01:24:31 +0100 Eric Bénard <eric@xxxxxxxxxx> wrote: > * on Telit & Sim.com modems, using encoding 0, opening a new DLC > randomly fails. Not setting PF bit of the control byte gives a > reliable behaviour on these modems. Any change needs doing with reference to the standard not modem specific hacks. Chances are the modem is right about the PF bit and we perhaps are not - but it's not an encoding dependant bit so the patch is certainly wrong. In this case: 5.4.3.1 says (of UI/UIH etc) 'both stations shall set the P bit to 0' so the modem is right and we are wrong. I think what is actually needed is to just remove the PF setting completely for that function. Obviously the other modems don't care or check the bit. Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
