On Tue, Dec 14, 2010 at 01:08:28PM -0800, Nick Pelly wrote: > On Tue, Dec 14, 2010 at 9:14 AM, Greg KH <greg@xxxxxxxxx> wrote: > > > > That's some subject: are you sure that should really be the subject? > > > > On Tue, Dec 14, 2010 at 11:49:46AM +0530, Mayank Rana wrote: > > > The driver was originally developed by Google. It is functionally > > > equivalent to the version available at: > > > http://android.git.kernel.org/?p=kernel/experimental.git > > > the differences being: > > > 1) Remove wakelocks and change unsupported DMA API. > > > 2) Replace clock selection register codes by macros. > > > 3) Fix checkpatch errors and add inline documentation. > > > 4) Add runtime PM hooks for active power state transitions. > > > > > > CC: Nick Pelly <npelly@xxxxxxxxxx> > > > Signed-off-by: Sankalp Bose <sankalpb@xxxxxxxxxxxxxx> > > > Signed-off-by: Mayank Rana <mrana@xxxxxxxxxxxxxx> > > > > <snip> > > > > I don't see the previous review comments I made addressed here, what > > happened? > > > > Specifically, you need to sort out the ownership of this file (who wrote > > the thing, why you are submitting something written by someone else > > without their approval, etc.) and the like. > > Glad someone is trying to get the patch upstream, but I think Mayank > has taken it a step backwards from the version on Android open source. > > Removing the wakelock's are fine since they are somewhat > controversial, and not core to the driver. Why are they removed? We now have the infrastructure in the kernel to keep them. I say put them back so you can use the same driver in the Android builds as well. > But adding all the boilerplate comments on each function? They add no value. For some functions, they can be helpful. > As far as authorship, I took the original Qualcomm driver and re-wrote > it. There is probably not a lot of code the same. The original driver > was very useful for regression testing though. A pointer to the original driver, and the copyright notice from it, and authorship information is needed in this version of the driver then. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
