On Tue, Nov 09, 2010 at 12:08:06PM -0800, dirk.brandewie@xxxxxxxxx wrote: > From: Dirk Brandewie <dirk.brandewie@xxxxxxxxx> > > This patch adds support for the PCI UART on the ce4100. > > Signed-off-by: Dirk Brandewie <dirk.brandewie@xxxxxxxxx> > CC: linux-serial@xxxxxxxxxxxxxxx > --- > drivers/serial/8250_pci.c | 35 +++++++++++++++++++++++++++++++++++ > include/linux/pci_ids.h | 1 + You did read the top of pci_ids.h right? Why are you adding new ids that are only used by one file? Please don't do that. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html