> > And huh, "grep -R serial_max3100.h *" gives what? Only max3100.c > > So do we need to remove serial_max3100.h as it's not used anywhere else? > > Yup, that sounds like a great idea, I'll go queue up that patch when I > get back from my travels at the moment. Sounds a very bad idea to me. The point of the platform data objects throughout the kernel is to allow other devices to use the driver without having to hack it up. Removing these interfaces breaks that. So NAK such a change. The existing code is right, the fact that the interface isn't being used in that way visibly by currently merged code doesn't mean it shouldn't be there. Also max3100 has an active maintainer so perhaps you should Cc them on such discussion ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
