On Thu, Oct 14, 2010 at 09:45:57PM +0200, Stanislav Brabec wrote: > Greg KH wrote: > > > This disparity appeared deliberately in 4547be78. If you need > > > no_console_suspend and the hardware lets the device in an undefined > > > state after resume (i. e. PXA270), you need to call subset of the > > > resume, even if the suspend counterpart was not called. Yes, I can > > > imagine that it may be a source of problems. > > > > It seems that support for no_console_suspend for all devices is becoming > > > more complicated. I guess that a new driver calls (maybe "save_state" > > > and "resume_state") or support for no_console_suspend directly in > > > drivers may be useful. > > > > Ok, so I'm guessing that this patch is not to be applied then, correct? > > I just compared it with Jason Wang's patches. MyungJoo Ham's patch is > exactly equal to the PATCH 1/2. So it already has my ACK and it is > pending as: > > serial-core: skip call set_termios/console_start when no_console_suspend Ah, ok, thanks for confirming this, no need for me to do anything else then, I like it :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
