On Tue, Sep 28, 2010 at 05:29:29PM +0200, Tobias Klauser wrote:
[...]
> > struct altera_uart {
> > struct uart_port port;
> > struct timer_list tmr;
> > + int bus_shift;
>
> This member is never used (only bus_shift from struct
> altera_uart_platform_uart). Seems to be a leftover.
Fixed, thanks!
> > unsigned int sigs; /* Local copy of line sigs */
> > unsigned short imr; /* Local IMR mirror */
> > };
> >
> > +static u32 altera_uart_readl(struct uart_port *port, int reg)
> > +{
> > + struct altera_uart_platform_uart *platp = port->private_data;
> > +
> > + return readl(port->membase + (reg << platp->bus_shift));
> > +}
> > +
> > +static void altera_uart_writel(struct uart_port *port, u32 dat, int reg)
> > +{
> > + struct altera_uart_platform_uart *platp = port->private_data;
> > +
> > + writel(dat, port->membase + (reg << platp->bus_shift));
> > +}
>
> Why not make these inline?
I trust the compiler. If it decides that the code would be
more optimal, it will inline them anyway. ;-)
Thanks,
--
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
