On Sat, Sep 25, 2010 at 12:50:40AM +0100, Alan Cox wrote: > > > This bit makes sense - but why can't you simply propogate it to the > > > existing uart_8250_port callback when registering ? > > > > > > I need a hook for platform code to reenable the UART block clocks before > > serial8250_set_sleep() is invoked on resume. The current code actually > > works, it's just that on resume the bootloader disables the clocks for > > all UART blocks except the debug one, which leaves all others dead. > > > > So I added the these calls into these platform methods around > > serial8250_set_sleep(). > > Which isn't the right way to do this IMHO. It may work for your specific > case but a solution needs to be generic. > > The comment about sticking it in the wrong structd also holds. > > So NAK this patch. Ok, I'll go drop the two patches in this series from my tree. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
