On Tuesday 07 October 2008, David Daney wrote: > > - up->port.type = PORT_16550A; > +#ifdef CONFIG_CPU_CAVIUM_OCTEON > + /* UPF_FIXED_PORT indicates an internal UART. */ > + if (up->port.flags & UPF_FIXED_PORT) > + up->port.type = PORT_OCTEON; > + else > +#endif > + up->port.type = PORT_16550A; > + This looks somewhat wrong, IMHO a device driver should not assume that a CONFIG_CPU_* symbol is exclusive. You could have (maybe not now, but in the future) a kernel that supports running on an Octeon as well as some other Mips64 processor, and have UPF_FIXED_PORT uart on some other machine, which will make the kernel think it is a PORT_OCTEON. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-serial" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
