On Fri, Jun 06, 2008 at 11:14:00AM +0100, Alan Cox wrote:
> On Fri, 6 Jun 2008 10:13:13 +0300
> "Catalin(ux) M BOIE" <catab@xxxxxxxxxxxxx> wrote:
>
> > It is a no-name PCI card. I found no reference to a producer so I
> > used the fake name "PDR".
>
> We don't really want to get fake names into pci_ids. I'd rather
>
>
> > .vendor = PCI_VENDOR_ID_PLX,
> > + .device = PCI_DEVICE_ID_PLX_9050,
> > + .subvendor = PCI_VENDOR_ID_PLX,
> > + .subdevice = PCI_SUBDEVICE_ID_PDR,
>
> Either the hex or a local and obviously unknown name like ID_UNKNOWN_1
>
>
> > + pbn_plx_pdr,
>
> _unknown1
>
> > pbn_oxsemi,
> > pbn_intel_i960,
> > pbn_sgi_ioc3,
> > @@ -1186,6 +1196,13 @@ static struct pciserial_board pci_boards[] __devinitdata = {
> > .base_baud = 115200,
> > .uart_offset = 8,
> > },
> > + /* PDR */
> > + [pbn_plx_pdr] = {
>
> Ditto
>
> > + /* PDR */
>
> Ditto
>
> > + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> > + PCI_VENDOR_ID_PLX,
> > + PCI_SUBDEVICE_ID_PDR, 0, 0,
>
> Ditto
>
>
> > +#define PCI_SUBDEVICE_ID_PDR 0x1584
> > +
>
> And not in here at all.
And there's no need for half the patch either - which I tried to explain
in a previous reply to Catalin but I just got repeated "My email address
has changed to ..." responses... so I gave up.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
