On Sunday 13 April 2008, Peter Korsgaard wrote:
> David> +/* work with hotplug and coldplug */
> David> +MODULE_ALIAS("platform:uartlite");
> David> +
>
> Why not stick this next to the other MODULE_ lines, like the other
> drivers?
Conceptually that's part of the driver struct ... it's not
metadata like who wrote it, its version, and so on. So I
prefer to keep it with that driver.
For example if the driver name changes that alias must change
too. And when the platform bus glue gets configured out -- with
PPC_MERGE, where OpenFirmware bus glue aranges for any hotplug
and coldplug suppoort, or in some other cases -- that alias must
be made to vanish.
So when I fix omissions in Kay's original patch, or otherwise
write the code myself, that's how I do it.
- Dave
> Other than that ..
>
> Acked-by: Peter Korsgaard <jacmet@xxxxxxxxxx>
>
> --
> Bye, Peter Korsgaard
>
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
