On Tue, Apr 08, 2008 at 11:38:11PM +0200, Jiri Slaby wrote:
>
> - static const char *badmagic =
> + static const char badmagic[] =
> KERN_ERR "sx: Warning: bad specialix port magic number for
> device %s in %s\n";
[...]
> if (port->magic != SPECIALIX_MAGIC) {
> printk(badmagic, name, routine);
> return 1;
> }
In a galaxy, far, far away, someone thought that this would save
memory. Especially if you print a message multiple times, the compiler
usually doesn't merge the string constants of two copies of:
printk (KERN_ERR "Bad magic number...");
Maybe it does now. (I don't think I came up with this. I probably
copied it over from somewhere....)
Roger.
--
** R.E.Wolff@xxxxxxxxxxxx ** http://www.BitWizard.nl/ ** +31-15-2600998 **
** Delftechpark 26 2628 XH Delft, The Netherlands. KVK: 27239233 **
*-- BitWizard writes Linux device drivers for any device you may have! --*
Q: It doesn't work. A: Look buddy, doesn't work is an ambiguous statement.
Does it sit on the couch all day? Is it unemployed? Please be specific!
Define 'it' and what it isn't doing. --------- Adapted from lxrbot FAQ
--
To unsubscribe from this list: send the line "unsubscribe linux-serial" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
