Re: [PATCH v1 net] sctp: Fix null-ptr-deref in reuseport_add_sock().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Dmitry Antipov <dmantipov@xxxxxxxxx>
Date: Wed, 31 Jul 2024 22:15:12 +0300
> On 7/31/24 10:06 PM, Kuniyuki Iwashima wrote:
> 
> > reuseport_lock is to synchronise operations within the same
> > reuseport group, but which socket should belong to which group
> > is out of scope.
> 
> Hm... then the lock should be a member of 'struct sock_reuseport'
> rather than global, isn't?

I thought that before and it would be doable with more complex
locking since we still need another synchronisation for add/detach
and alloc.  Such operations are most unlikely done concurrently
nor frequently, and the global lock would be enough.

I'll check that again later, but anyway, it's a different topic
for net-next.




[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     SCTP

  Powered by Linux