On Tue, Oct 3, 2023 at 10:23 AM Florian Westphal <fw@xxxxxxxxx> wrote: > > Xin Long <lucien.xin@xxxxxxxxx> wrote: > > > The type of vtag is u32. But the type of ct->proto.sctp.vtag[!dir] and init_tag > > > is __be32. This doesn't seem right (and makes Sparse unhappy). > > You're right, I will fix it and re-post with tag: > > > > Fixes: 9fb9cbb1082d ("[NETFILTER]: Add nf_conntrack subsystem.") > > I'm fine with this, the bug is likely inherited from > ipt_conntrack_sctp.c, but that doesn't exist anymore. ah, I see. > > Would you also fix up the __be32/u32 confusion? > > Better to not add more sparse warnings... > yes, I will fix the __be32 one too. Thanks.