On Sun, Oct 01, 2023 at 11:04:20AM -0400, Xin Long wrote: > Currently, when hb_interval is changed by users, it won't take effect > until the next expiry of hb timer. As the default value is 30s, users > have to wait up to 30s to wait its hb_interval update to work. > > This becomes pretty bad in containers where a much smaller value is > usually set on hb_interval. This patch improves it by resetting the > hb timer immediately once the value of hb_interval is updated by users. > > Note that we don't address the already existing 'problem' when sending > a heartbeat 'on demand' if one hb has just been sent(from the timer) > mentioned in: > > https://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg590224.html Hi Xin Long, I wonder if this warrants a fixes tag, and if so, perhaps: Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Xin Long <lucien.xin@xxxxxxxxx> Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
