On 6/19/23 2:28 AM, Pavel Begunkov wrote: > That callback is all about file dependent operations, just like ioctl. > And as the patch in question is doing socket specific stuff, I think > architecturally it fits well. I also believe Breno wants to extend it > later to support more operations. > > Sockets are a large chunk of use cases, it can be implemented as a > separate io_uring request type if nothing else works, but in general > that might not be as scalable. The io_uring commands are wrappers to existing networking APIs - doing via io_uring what userspace apps can do via system calls. As such, the translations should be done in io_uring code and then invoking in-kernel APIs. Same comment applies to sockopts when those come around and any other future extensions.