Re: [PATCH net-next 5/7] sctp: add dif and sdif check in asoc and ep lookup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 13, 2022 at 3:15 PM kernel test robot <lkp@xxxxxxxxx> wrote:
>
> Hi Xin,
>
> Thank you for the patch! Yet something to improve:
>
> [auto build test ERROR on net-next/master]
>
> url:    https://github.com/intel-lab-lkp/linux/commits/Xin-Long/sctp-support-vrf-processing/20221114-004540
> patch link:    https://lore.kernel.org/r/86dfdc49613ca8a8a6a3d7c7cf2e7bd8207338f2.1668357542.git.lucien.xin%40gmail.com
> patch subject: [PATCH net-next 5/7] sctp: add dif and sdif check in asoc and ep lookup
> config: arm-randconfig-r034-20221114
> compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 463da45892e2d2a262277b91b96f5f8c05dc25d0)
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # install arm cross compiling tool for clang build
>         # apt-get install binutils-arm-linux-gnueabi
>         # https://github.com/intel-lab-lkp/linux/commit/6129dc2e382c6e2d3198f6c32cc1f750a15a77ab
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Xin-Long/sctp-support-vrf-processing/20221114-004540
>         git checkout 6129dc2e382c6e2d3198f6c32cc1f750a15a77ab
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash net/openvswitch/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
>
> All errors (new ones prefixed by >>):
>
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
The build disabled IP_SCTP, while net/sctp/sctp.h is included in other modules.
Instead of "net/sctp/sctp.h", "linux/sctp.h" should be included, I
will send another patch series to fix them.

We do NOT need to change anything in this series.

Thanks.

>    include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
>            compiletime_assert_rwonce_type(x);                              \
>                                           ^
>    include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
>            compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
>                                             ^
>    include/linux/compiler_types.h:324:10: note: expanded from macro '__native_word'
>            (sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
>                    ^
>    include/linux/compiler_types.h:357:22: note: expanded from macro 'compiletime_assert'
>            _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                ^~~~~~~~~
>    include/linux/compiler_types.h:345:23: note: expanded from macro '_compiletime_assert'
>            __compiletime_assert(condition, msg, prefix, suffix)
>                                 ^~~~~~~~~
>    include/linux/compiler_types.h:337:9: note: expanded from macro '__compiletime_assert'
>                    if (!(condition))                                       \
>                          ^~~~~~~~~
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
>    include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
>            compiletime_assert_rwonce_type(x);                              \
>                                           ^
>    include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
>            compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
>                                             ^
>    include/linux/compiler_types.h:324:39: note: expanded from macro '__native_word'
>            (sizeof(t) == sizeof(char) || sizeof(t) == sizeof(short) || \
>                                                 ^
>    include/linux/compiler_types.h:357:22: note: expanded from macro 'compiletime_assert'
>            _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                ^~~~~~~~~
>    include/linux/compiler_types.h:345:23: note: expanded from macro '_compiletime_assert'
>            __compiletime_assert(condition, msg, prefix, suffix)
>                                 ^~~~~~~~~
>    include/linux/compiler_types.h:337:9: note: expanded from macro '__compiletime_assert'
>                    if (!(condition))                                       \
>                          ^~~~~~~~~
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
>    include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
>            compiletime_assert_rwonce_type(x);                              \
>                                           ^
>    include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
>            compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
>                                             ^
>    include/linux/compiler_types.h:325:10: note: expanded from macro '__native_word'
>             sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
>                    ^
>    include/linux/compiler_types.h:357:22: note: expanded from macro 'compiletime_assert'
>            _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                ^~~~~~~~~
>    include/linux/compiler_types.h:345:23: note: expanded from macro '_compiletime_assert'
>            __compiletime_assert(condition, msg, prefix, suffix)
>                                 ^~~~~~~~~
>    include/linux/compiler_types.h:337:9: note: expanded from macro '__compiletime_assert'
>                    if (!(condition))                                       \
>                          ^~~~~~~~~
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
>    include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
>            compiletime_assert_rwonce_type(x);                              \
>                                           ^
>    include/asm-generic/rwonce.h:36:35: note: expanded from macro 'compiletime_assert_rwonce_type'
>            compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
>                                             ^
>    include/linux/compiler_types.h:325:38: note: expanded from macro '__native_word'
>             sizeof(t) == sizeof(int) || sizeof(t) == sizeof(long))
>                                                ^
>    include/linux/compiler_types.h:357:22: note: expanded from macro 'compiletime_assert'
>            _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                ^~~~~~~~~
>    include/linux/compiler_types.h:345:23: note: expanded from macro '_compiletime_assert'
>            __compiletime_assert(condition, msg, prefix, suffix)
>                                 ^~~~~~~~~
>    include/linux/compiler_types.h:337:9: note: expanded from macro '__compiletime_assert'
>                    if (!(condition))                                       \
>                          ^~~~~~~~~
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
>    include/asm-generic/rwonce.h:49:33: note: expanded from macro 'READ_ONCE'
>            compiletime_assert_rwonce_type(x);                              \
>                                           ^
>    include/asm-generic/rwonce.h:36:48: note: expanded from macro 'compiletime_assert_rwonce_type'
>            compiletime_assert(__native_word(t) || sizeof(t) == sizeof(long long),  \
>                                                          ^
>    include/linux/compiler_types.h:357:22: note: expanded from macro 'compiletime_assert'
>            _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
>                                ^~~~~~~~~
>    include/linux/compiler_types.h:345:23: note: expanded from macro '_compiletime_assert'
>            __compiletime_assert(condition, msg, prefix, suffix)
>                                 ^~~~~~~~~
>    include/linux/compiler_types.h:337:9: note: expanded from macro '__compiletime_assert'
>                    if (!(condition))                                       \
>                          ^~~~~~~~~
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
>    include/asm-generic/rwonce.h:50:14: note: expanded from macro 'READ_ONCE'
>            __READ_ONCE(x);                                                 \
>                        ^
>    include/asm-generic/rwonce.h:44:65: note: expanded from macro '__READ_ONCE'
>    #define __READ_ONCE(x)  (*(const volatile __unqual_scalar_typeof(x) *)&(x))
>                                                                     ^
>    include/linux/compiler_types.h:313:13: note: expanded from macro '__unqual_scalar_typeof'
>                    _Generic((x),                                           \
>                              ^
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
>    include/asm-generic/rwonce.h:50:14: note: expanded from macro 'READ_ONCE'
>            __READ_ONCE(x);                                                 \
>                        ^
>    include/asm-generic/rwonce.h:44:65: note: expanded from macro '__READ_ONCE'
>    #define __READ_ONCE(x)  (*(const volatile __unqual_scalar_typeof(x) *)&(x))
>                                                                     ^
>    include/linux/compiler_types.h:320:15: note: expanded from macro '__unqual_scalar_typeof'
>                             default: (x)))
>                                       ^
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:35: error: no member named 'sctp' in 'struct net'
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                                        ~~~  ^
>    include/asm-generic/rwonce.h:50:14: note: expanded from macro 'READ_ONCE'
>            __READ_ONCE(x);                                                 \
>                        ^
>    include/asm-generic/rwonce.h:44:72: note: expanded from macro '__READ_ONCE'
>    #define __READ_ONCE(x)  (*(const volatile __unqual_scalar_typeof(x) *)&(x))
>                                                                            ^
>    In file included from net/openvswitch/actions.c:26:
>    In file included from include/net/sctp/checksum.h:27:
> >> include/net/sctp/sctp.h:686:19: error: invalid argument type 'void' to unary expression
>            l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    9 errors generated.
>
>
> vim +686 include/net/sctp/sctp.h
>
>    679
>    680  static inline bool sctp_sk_bound_dev_eq(struct net *net, int bound_dev_if,
>    681                                          int dif, int sdif)
>    682  {
>    683          bool l3mdev_accept = true;
>    684
>    685  #if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV)
>  > 686          l3mdev_accept = !!READ_ONCE(net->sctp.l3mdev_accept);
>    687  #endif
>    688          return inet_bound_dev_eq(l3mdev_accept, bound_dev_if, dif, sdif);
>    689  }
>    690
>
> --
> 0-DAY CI Kernel Test Service
> https://01.org/lkp



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     SCTP

  Powered by Linux