On Thu, Apr 21, 2022 at 6:18 AM David Miller <davem@xxxxxxxxxxxxx> wrote: > > From: Xin Long <lucien.xin@xxxxxxxxx> > Date: Wed, 20 Apr 2022 16:52:41 -0400 > > > diff --git a/net/sctp/sm_sideeffect.c b/net/sctp/sm_sideeffect.c > > index b3815b568e8e..463c4a58d2c3 100644 > > --- a/net/sctp/sm_sideeffect.c > > +++ b/net/sctp/sm_sideeffect.c > > @@ -458,6 +458,10 @@ void sctp_generate_reconf_event(struct timer_list *t) > > goto out_unlock; > > } > > > > + /* This happens when the response arrives after the timer is triggered. */ > > + if (!asoc->strreset_chunk) > > + goto out_unlock; > > + > This will return 0 because that is error's value right there, intentional? intentional, this won't be treated as an error.