Hi! > static inline void *test_malloc(size_t size) > { > void *buf = malloc(size); > - if (NULL == buf) > - tst_brkm(TBROK, tst_exit, "malloc failed"); > + > + if (NULL == buf) > + tst_brkm(TBROK, tst_exit, "malloc failed"); This one has still constant on the right and I would rather change this to the more common if (!buf) variant as well. Other than that it's pretty obviously fine: Reviewed-by: Cyril Hrubis <chrubis@xxxxxxx> > return buf; > } > > -- > 2.35.1 > -- Cyril Hrubis chrubis@xxxxxxx