Re: [PATCH net 1/4] sctp: validate from_addr_param return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 27, 2021 at 04:20:22AM +0200, Ben Hutchings wrote:
> On Mon, Jun 28, 2021 at 04:13:41PM -0300, Marcelo Ricardo Leitner wrote:
> [...]
> > @@ -1174,7 +1175,8 @@ static struct sctp_association *__sctp_rcv_asconf_lookup(
> >  	if (unlikely(!af))
> >  		return NULL;
> >  
> > -	af->from_addr_param(&paddr, param, peer_port, 0);
> > +	if (af->from_addr_param(&paddr, param, peer_port, 0))
> > +		return NULL;
> >  
> >  	return __sctp_lookup_association(net, laddr, &paddr, transportp);
> >  }
> [...]
> 
> This condition needs to be inverted, doesn't it?

Right you are. I'll send a patch today.

Thanks,
Marcelo



[Index of Archives]     [Linux Networking Development]     [Linux OMAP]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     SCTP

  Powered by Linux